refactor: replace hardcoded 'en' defaults with LIBRARY_DEFAULT_LOCALE - #13
Merged
eoinest merged 4 commits intoMar 7, 2026
Conversation
The intl-messageformat package doesn't depend on generaltranslation, so importing from generaltranslation._settings would break standalone installs. Define the constant locally instead.
eoinest
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all hardcoded
"en"locale defaults in source code with the existingLIBRARY_DEFAULT_LOCALEconstant fromgeneraltranslation._settings.This ensures there's a single source of truth for the default locale across all packages:
gt-fastapiandgt-flasksetup functionsgeneraltranslation-intl-messageformatformatterNo behavioral change —
LIBRARY_DEFAULT_LOCALEis already defined as"en".